Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/169: Set session cookie only if non-empty #170

Merged
merged 3 commits into from
Oct 26, 2022
Merged

issues/169: Set session cookie only if non-empty #170

merged 3 commits into from
Oct 26, 2022

Conversation

komuw
Copy link
Owner

@komuw komuw commented Oct 26, 2022

What:

  • Set session cookie only if non-empty
  • I was unable to add a testcase, but I did test manually and it seems okay

Why:

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Base: 71.60% // Head: 71.34% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (e3f1ee9) compared to base (2306e72).
Patch coverage: 73.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   71.60%   71.34%   -0.27%     
==========================================
  Files          30       30              
  Lines        2071     2066       -5     
==========================================
- Hits         1483     1474       -9     
- Misses        516      518       +2     
- Partials       72       74       +2     
Impacted Files Coverage Δ
sess/sess.go 83.33% <73.33%> (-8.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw marked this pull request as ready for review October 26, 2022 09:41
@komuw komuw merged commit 91e474d into main Oct 26, 2022
@komuw komuw deleted the issues/169 branch October 26, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

too many session cookies are been set
2 participants